Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to changes.md about firefix minimum version #11442

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Add note to changes.md about firefix minimum version #11442

merged 1 commit into from
Aug 1, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Aug 1, 2023

In light of #11400, this adds a heads-up to CHANGES.md to warn of the updated Firefox browser requirement.

@ggetz ggetz requested a review from jjhembd August 1, 2023 13:43
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ❕ There was an error checking the CLA! If this is your first contribution, please send in a Contributor License Agreement.
    • Maintainers, this was the error I ran into while attempting to process the CLA check. Please resolve it to continue CLA checking.
    • You'll need to manually check for a submitted CLA
    Error: The service is currently unavailable.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@jjhembd jjhembd mentioned this pull request Aug 1, 2023
Closed
jjhembd
jjhembd approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz!

@jjhembd jjhembd merged commit 91d84fd into main Aug 1, 2023
2 checks passed
@jjhembd jjhembd deleted the changes-ff-announcement branch August 1, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjhembd jjhembd jjhembd approved these changes

Assignees
No one assigned
Labels
priority - next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggetz @cesium-concierge @jjhembd